Standardise HTTPServer and StreamServer data types #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP and Stream servers were dealing with different datatypes Datatypes should remain the same so wrapper functions can be written with ease
isaachawley
approved these changes
Jun 18, 2018
This comment has been minimized.
This comment has been minimized.
Dean-Coakley
force-pushed
the
master
branch
3 times, most recently
from
ea59995 to
76c610f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP and Stream servers were dealing with different datatypes
Datatypes should remain the same so wrapper functions can be written
with ease